usb: core: hcd: change sizeof(vaddr) to sizeof(unsigned long)
authorGuo Zhengkui <guozhengkui@vivo.com>
Thu, 9 Dec 2021 06:23:05 +0000 (14:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Dec 2021 14:03:18 +0000 (15:03 +0100)
`vaddr` is a pointer to unsigned char. sizeof(vaddr) here intends
to get the size of a pointer. But readers may get confused. Change
sizeof(vaddr) to sizeof(unsigned long) makes more sense.

Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Link: https://lore.kernel.org/r/20211209062441.9856-1-guozhengkui@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hcd.c

index 4d326ee..9ffc63a 100644 (file)
@@ -1281,7 +1281,7 @@ static int hcd_alloc_coherent(struct usb_bus *bus,
                return -EFAULT;
        }
 
-       vaddr = hcd_buffer_alloc(bus, size + sizeof(vaddr),
+       vaddr = hcd_buffer_alloc(bus, size + sizeof(unsigned long),
                                 mem_flags, dma_handle);
        if (!vaddr)
                return -ENOMEM;