adaptivedemux2: fix critical when using an unsupported URI

adaptivedemux2 only supports http(s), trying to use it with, say,
file:// was raising a CRITICAL in libsoup.

Fix #2476

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4421>

diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c
index 817348d..8e7c080 100644 (file)
--- a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c
+++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c
@@ -953,6 +953,15 @@ handle_incoming_manifest (GstAdaptiveDemux * demux)
 
     GST_DEBUG_OBJECT (demux, "Fetched manifest at URI: %s (base: %s)",
         demux->manifest_uri, GST_STR_NULL (demux->manifest_base_uri));
+
+    if (!g_str_has_prefix (demux->manifest_uri, "http://")
+        && !g_str_has_prefix (demux->manifest_uri, "https://")) {
+      GST_ELEMENT_ERROR (demux, STREAM, DEMUX,
+          (_("Invalid manifest URI")),
+          ("Manifest URI needs to use either http:// or https://"));
+      ret = FALSE;
+      goto unlock_out;
+    }
   } else {
     GST_WARNING_OBJECT (demux, "Upstream URI query failed.");
   }