projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6054d97
)
firmware: arm_scmi: Fix call site of scmi_notification_exit
author
Cristian Marussi
<cristian.marussi@arm.com>
Tue, 12 Jan 2021 19:13:26 +0000
(19:13 +0000)
committer
Sudeep Holla
<sudeep.holla@arm.com>
Wed, 13 Jan 2021 14:30:16 +0000
(14:30 +0000)
Call scmi_notification_exit() only when SCMI platform driver instance has
been really successfully removed.
Link:
https://lore.kernel.org/r/20210112191326.29091-1-cristian.marussi@arm.com
Fixes:
6b8a69131dc63
("firmware: arm_scmi: Enable notification core")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
[sudeep.holla: Move the call outside the list mutex locking]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/driver.c
patch
|
blob
|
history
diff --git
a/drivers/firmware/arm_scmi/driver.c
b/drivers/firmware/arm_scmi/driver.c
index
5392e1f
..
cacdf15
100644
(file)
--- a/
drivers/firmware/arm_scmi/driver.c
+++ b/
drivers/firmware/arm_scmi/driver.c
@@
-848,8
+848,6
@@
static int scmi_remove(struct platform_device *pdev)
struct scmi_info *info = platform_get_drvdata(pdev);
struct idr *idr = &info->tx_idr;
- scmi_notification_exit(&info->handle);
-
mutex_lock(&scmi_list_mutex);
if (info->users)
ret = -EBUSY;
@@
-860,6
+858,8
@@
static int scmi_remove(struct platform_device *pdev)
if (ret)
return ret;
+ scmi_notification_exit(&info->handle);
+
/* Safe to free channels since no more users */
ret = idr_for_each(idr, info->desc->ops->chan_free, idr);
idr_destroy(&info->tx_idr);