Realize IWYU pattern for handles.h header.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1290453002

Cr-Commit-Position: refs/heads/master@{#30110}

diff --git a/src/accessors.h b/src/accessors.h
index 41397be79f70598b997ea708ef7d58b7ccfaec1a..3c0079de89dcc58d3c5f21f2ee08f1b86b6422ed 100644 (file)
--- a/src/accessors.h
+++ b/src/accessors.h
@@ -14,6 +14,9 @@
 namespace v8 {
 namespace internal {
 
+// Forward declarations.
+class ExecutableAccessorInfo;
+
 // The list of accessor descriptors. This is a second-order macro
 // taking a macro to be applied to all accessor descriptor names.
 #define ACCESSOR_INFO_LIST(V)     \

diff --git a/src/api-natives.h b/src/api-natives.h
index 224c78a6adb421fcb62ad75394ab4af83bfaac3b..c5e398296cfb840c52efb0679177ac3995aa8e04 100644 (file)
--- a/src/api-natives.h
+++ b/src/api-natives.h
@@ -6,10 +6,15 @@
 #define V8_API_NATIVES_H_
 
 #include "src/handles.h"
+#include "src/property-details.h"
 
 namespace v8 {
 namespace internal {
 
+// Forward declarations.
+class ObjectTemplateInfo;
+class TemplateInfo;
+
 class ApiNatives {
  public:
   static const int kInitialFunctionCacheSize = 256;

diff --git a/src/compiler/simplified-operator.h b/src/compiler/simplified-operator.h
index 1460cb04f35298f6b3d3e460eee825baa845a9c1..447bf9e5e92c87215155e29904d9b71921611a9a 100644 (file)
--- a/src/compiler/simplified-operator.h
+++ b/src/compiler/simplified-operator.h
@@ -9,6 +9,7 @@
 
 #include "src/compiler/machine-type.h"
 #include "src/handles.h"
+#include "src/objects.h"
 
 namespace v8 {
 namespace internal {

diff --git a/src/execution.h b/src/execution.h
index fd7636db96103d451ebdc999c3f0939569f07392..551682c2eb65637864e751e555c6a5df98c9565e 100644 (file)
--- a/src/execution.h
+++ b/src/execution.h
@@ -5,11 +5,17 @@
 #ifndef V8_EXECUTION_H_
 #define V8_EXECUTION_H_
 
+#include "src/allocation.h"
+#include "src/base/atomicops.h"
 #include "src/handles.h"
+#include "src/utils.h"
 
 namespace v8 {
 namespace internal {
 
+// Forward declarations.
+class JSRegExp;
+
 class Execution final : public AllStatic {
  public:
   // Call a function, the caller supplies a receiver and an array

diff --git a/src/futex-emulation.h b/src/futex-emulation.h
index 2a07f332d56fc472d3c7fef2028573780ba3bef9..86b5f78811b0a32a541e7e76f16daae7642e9e0d 100644 (file)
--- a/src/futex-emulation.h
+++ b/src/futex-emulation.h
@@ -31,6 +31,7 @@ class TimeDelta;
 namespace internal {
 
 class Isolate;
+class JSArrayBuffer;
 
 class FutexWaitListNode {
  public:

diff --git a/src/handles.h b/src/handles.h
index 841a83ba6044f81a7bc418792fcf3465b0eab38b..2db18307dacad563b89a5ba3eea179eb43b9b85e 100644 (file)
--- a/src/handles.h
+++ b/src/handles.h
@@ -5,7 +5,10 @@
 #ifndef V8_HANDLES_H_
 #define V8_HANDLES_H_
 
-#include "src/objects.h"
+#include "include/v8.h"
+#include "src/base/macros.h"
+#include "src/checks.h"
+#include "src/globals.h"
 
 namespace v8 {
 namespace internal {
@@ -13,6 +16,8 @@ namespace internal {
 // Forward declarations.
 class DeferredHandles;
 class HandleScopeImplementer;
+class Isolate;
+class Object;
 
 
 // ----------------------------------------------------------------------------
@@ -25,9 +30,9 @@ class HandleBase {
   // Check if this handle refers to the exact same object as the other handle.
   V8_INLINE bool is_identical_to(const HandleBase that) const {
     // Dereferencing deferred handles to check object equality is safe.
-    SLOW_DCHECK((this->location_ == NULL ||
+    SLOW_DCHECK((this->location_ == nullptr ||
                  this->IsDereferenceAllowed(NO_DEFERRED_CHECK)) &&
-                (that.location_ == NULL ||
+                (that.location_ == nullptr ||
                  that.IsDereferenceAllowed(NO_DEFERRED_CHECK)));
     if (this->location_ == that.location_) return true;
     if (this->location_ == NULL || that.location_ == NULL) return false;
@@ -45,7 +50,7 @@ class HandleBase {
 
   // Returns the address to where the raw pointer is stored.
   V8_INLINE Object** location() const {
-    SLOW_DCHECK(location_ == NULL ||
+    SLOW_DCHECK(location_ == nullptr ||
                 IsDereferenceAllowed(INCLUDE_DEFERRED_CHECK));
     return location_;
   }

diff --git a/src/i18n.h b/src/i18n.h
index 98c4af7f27ee4d1cc616a8c58fab4a45ed903116..ea8380baa720b7d7221335126c90da3ad7861ba1 100644 (file)
--- a/src/i18n.h
+++ b/src/i18n.h
@@ -19,6 +19,9 @@ class SimpleDateFormat;
 namespace v8 {
 namespace internal {
 
+// Forward declarations.
+class ObjectTemplateInfo;
+
 class I18N {
  public:
   // Creates an ObjectTemplate with one internal field.

diff --git a/src/messages.h b/src/messages.h
index d00eec0fc2131c5740f40103b0ac6a4bc864dcf4..304db7cd216eb57c6ae2fccb0550d7c871a86aa0 100644 (file)
--- a/src/messages.h
+++ b/src/messages.h
@@ -10,33 +10,15 @@
 #ifndef V8_MESSAGES_H_
 #define V8_MESSAGES_H_
 
-// Forward declaration of MessageLocation.
-namespace v8 {
-namespace internal {
-class MessageLocation;
-} }  // namespace v8::internal
-
-
-class V8Message {
- public:
-  V8Message(char* type,
-            v8::internal::Handle<v8::internal::JSArray> args,
-            const v8::internal::MessageLocation* loc) :
-      type_(type), args_(args), loc_(loc) { }
-  char* type() const { return type_; }
-  v8::internal::Handle<v8::internal::JSArray> args() const { return args_; }
-  const v8::internal::MessageLocation* loc() const { return loc_; }
- private:
-  char* type_;
-  v8::internal::Handle<v8::internal::JSArray> const args_;
-  const v8::internal::MessageLocation* loc_;
-};
-
+#include "src/base/smart-pointers.h"
+#include "src/list.h"
 
 namespace v8 {
 namespace internal {
 
-struct Language;
+// Forward declarations.
+class JSMessageObject;
+class LookupIterator;
 class SourceInfo;
 
 class MessageLocation {

diff --git a/src/string-stream.h b/src/string-stream.h
index 7aa5fd7db3d3e293e4d20a4c3a514f53dcf20615..d03f1b04c9c89b86583aceddc2a8017ba1c0555b 100644 (file)
--- a/src/string-stream.h
+++ b/src/string-stream.h
@@ -5,11 +5,17 @@
 #ifndef V8_STRING_STREAM_H_
 #define V8_STRING_STREAM_H_
 
+#include "src/allocation.h"
+#include "src/base/smart-pointers.h"
 #include "src/handles.h"
+#include "src/vector.h"
 
 namespace v8 {
 namespace internal {
 
+// Forward declarations.
+class ByteArray;
+
 class StringAllocator {
  public:
   virtual ~StringAllocator() { }