http: fix setting ServerResponse.statusCode in writeHead

Fixes #1374.

diff --git a/lib/http.js b/lib/http.js
index b61be65..a029714 100644 (file)
--- a/lib/http.js
+++ b/lib/http.js
@@ -798,6 +798,7 @@ ServerResponse.prototype.writeHead = function(statusCode) {
     reasonPhrase = STATUS_CODES[statusCode] || 'unknown';
     headerIndex = 1;
   }
+  this.statusCode = statusCode;
 
   var obj = arguments[headerIndex];
 

diff --git a/test/simple/test-http-status-code.js b/test/simple/test-http-status-code.js
new file mode 100644 (file)
index 0000000..5edd81f
--- /dev/null
+++ b/test/simple/test-http-status-code.js
@@ -0,0 +1,66 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common');
+var assert = require('assert');
+var http = require('http');
+
+// Simple test of Node's HTTP ServerResponse.statusCode
+// ServerResponse.prototype.statusCode
+
+var testsComplete = 0;
+var tests = [200, 202, 300, 404, 500];
+var testIdx = 0;
+
+var s = http.createServer(function(req, res) {
+  var t = tests[testIdx];
+  res.writeHead(t, {'Content-Type': 'text/plain'});
+  console.log('--\nserver: statusCode after writeHead: '+res.statusCode);
+  assert.equal(res.statusCode, t);
+  res.end('hello world\n');
+});
+
+s.listen(common.PORT, nextTest);
+
+
+function nextTest () {
+  if (testIdx + 1 === tests.length) {
+    return s.close();
+  }
+  var test = tests[testIdx];
+
+  http.get({ port: common.PORT }, function(response) {
+    console.log('client: expected status: ' + test);
+    console.log('client: statusCode: ' + response.statusCode);
+    assert.equal(response.statusCode, test);
+    response.on('end', function() {
+      testsComplete++;
+      testIdx += 1;
+      nextTest();
+    });
+  });
+}
+
+
+process.on('exit', function() {
+  assert.equal(4, testsComplete);
+});
+