Remove pylint warnings

Change-Id: I5cafb9637fea36d9612c708fc57daba302f19648

diff --git a/gitbuildsys/cmd_build.py b/gitbuildsys/cmd_build.py
index 5ab3329385dfebd5360b676598136c3a255c5a01..34704dd1a56dcbd5b2eb2015ec865a2a6a429411 100644 (file)
--- a/gitbuildsys/cmd_build.py
+++ b/gitbuildsys/cmd_build.py
@@ -20,8 +20,6 @@
 """
 
 import os
-import subprocess
-import tempfile
 import shutil
 import pwd
 import re

diff --git a/gitbuildsys/cmd_remotebuild.py b/gitbuildsys/cmd_remotebuild.py
index 2021d6c44eb03f0d01e357490df87baba0b05e8d..998937830123a0d3ba0e8eaf0f937233e1298f98 100644 (file)
--- a/gitbuildsys/cmd_remotebuild.py
+++ b/gitbuildsys/cmd_remotebuild.py
@@ -208,7 +208,7 @@ def main(args):
         try:
             api.commit_files(target_prj, package, commit_files, commit_msg)
         except errors.ObsError, exc:
-            msger.error('commit packages fail: %s, please check the permission '\
+            msger.error('commit packages fail: %s, please check the permission '
                         'of target project:%s' % (exc, target_prj))
 
         msger.info('local changes submitted to build server successfully')

diff --git a/gitbuildsys/cmd_submit.py b/gitbuildsys/cmd_submit.py
index e9f8506b215f25d0ce1f0642798ccde527ff5034..4382d1b7fdd58d4da29add95360d651cd1ec8f46 100644 (file)
--- a/gitbuildsys/cmd_submit.py
+++ b/gitbuildsys/cmd_submit.py
@@ -21,7 +21,7 @@
 import os
 import time
 
-from gitbuildsys import msger, errors
+from gitbuildsys import msger
 
 from gbp.rpm.git import GitRepositoryError, RpmGitRepository
 
@@ -45,7 +45,7 @@ def main(args):
         upstream = repo.get_upstream_branch(current_branch)
     except GitRepositoryError:
         upstream = None
-        pass
+
     if not args.remote:
         if upstream:
             args.remote = upstream.split('/')[0]

diff --git a/gitbuildsys/conf.py b/gitbuildsys/conf.py
index bd2067aaa883a5576100c8bfe3911d880d181dc7..96a57c9a69cb102cf43c290f7da08374ad683858 100644 (file)
--- a/gitbuildsys/conf.py
+++ b/gitbuildsys/conf.py
@@ -564,8 +564,8 @@ class BizConfigManager(ConfigMgr):
     def build_profile_by_name(self, name):
         '''return profile object by a given section'''
         if not name.startswith('profile.'):
-            raise errors.ConfigError('section name specified by general.profile '
-                'must start with string "profile.": %s' % name)
+            raise errors.ConfigError('section name specified by general.profile'
+                ' must start with string "profile.": %s' % name)
         if not self.has_section(name):
             raise errors.ConfigError('no such section: %s' % name)
 
@@ -651,8 +651,8 @@ class BizConfigManager(ConfigMgr):
             url = URL(addr, user, password)
 
             obsconf = OBSConf(profile, 'obs.%s' % sec, url,
-                              self.get_optional_item('remotebuild', 'base_prj'),
-                              self.get_optional_item('remotebuild', 'target_prj'))
+                self.get_optional_item('remotebuild', 'base_prj'),
+                self.get_optional_item('remotebuild', 'target_prj'))
             profile.set_obs(obsconf)
 
         repos = self._parse_build_repos()

diff --git a/gitbuildsys/oscapi.py b/gitbuildsys/oscapi.py
index b1461446e8502ace43ecb99499eb2b8effb6f832..831772747e4fee4c10c73eafd16363de90a8b69f 100644 (file)
--- a/gitbuildsys/oscapi.py
+++ b/gitbuildsys/oscapi.py
@@ -261,7 +261,7 @@ class OSC(object):
                 try:
                     response = self.core_http(core.http_GET, url).read()
                     entries = core.ET.fromstring(response)
-                   break
+                    break
                 except OSCError, err:
                     raise ObsError("can't get list of sources from"\
                                    " %s/%s: %s" % (prj, pkg, err))

diff --git a/gitbuildsys/utils.py b/gitbuildsys/utils.py
index 11a27fb1d5c690193a96b2cca1f3d935707fe8cc..b2c5385e132c4ac217e4b45a4dba1cf5ee189013 100644 (file)
--- a/gitbuildsys/utils.py
+++ b/gitbuildsys/utils.py
@@ -341,9 +341,10 @@ class RepoParser(object):
                                                  meta['buildconf'])
         fname = self.fetch(buildconf_url)
         if fname:
-            release, buildid = meta['id'].split('_')
+            release, _buildid = meta['id'].split('_')
             release = release.replace('-','')
-            target_conf = os.path.join(os.path.dirname(fname), '%s.conf' % release)
+            target_conf = os.path.join(os.path.dirname(fname),
+                                       '%s.conf' % release)
             os.rename(fname, target_conf)
             self.buildconf = target_conf