PR feedback nits

Commit migrated from https://github.com/dotnet/corefx/commit/13ad3d0b841a611e775f51bd66375c9587584a72

diff --git a/src/libraries/System.IO.Ports/tests/System.IO.Ports.Tests.csproj b/src/libraries/System.IO.Ports/tests/System.IO.Ports.Tests.csproj
index 05c717c..1be36a0 100644 (file)
--- a/src/libraries/System.IO.Ports/tests/System.IO.Ports.Tests.csproj
+++ b/src/libraries/System.IO.Ports/tests/System.IO.Ports.Tests.csproj
@@ -110,7 +110,7 @@
     <Compile Include="Support\PortsTest.cs" />
     <Compile Include="Support\TestEventHandler.cs" />
   </ItemGroup>
-  <ItemGroup Condition="'$(TargetsLinux)' != 'true' AND '$(TargetsOSX)' != 'true'">
+  <ItemGroup Condition="'$(TargetsWindows)' == 'true'">
     <Compile Include="SerialPort\DosDevices.cs" />
     <Compile Include="SerialPort\PortName.cs" />
     <Compile Include="SerialPort\OpenDevices.cs" />

diff --git a/src/libraries/System.Reflection.Metadata/tests/Configurations.props b/src/libraries/System.Reflection.Metadata/tests/Configurations.props
index d2afc7a..1a037ad 100644 (file)
--- a/src/libraries/System.Reflection.Metadata/tests/Configurations.props
+++ b/src/libraries/System.Reflection.Metadata/tests/Configurations.props
@@ -1,10 +1,8 @@
 <Project>
   <PropertyGroup>
-    <!-- uap build currently failing: https://github.com/dotnet/corefx/issues/31962 -->
     <BuildConfigurations>
       netcoreapp;
       netfx;
-      <!-- uap; -->
     </BuildConfigurations>
   </PropertyGroup>
 </Project>
\ No newline at end of file

diff --git a/src/libraries/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj b/src/libraries/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj
index 5f1df61..3b8c014 100644 (file)
--- a/src/libraries/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj
+++ b/src/libraries/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj
@@ -3,8 +3,7 @@
     <ProjectGuid>{7061832A-E8CF-4AB6-A8DC-44D2F5A43A13}</ProjectGuid>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <ExternallyShipping>false</ExternallyShipping>
-    <!-- UAP build currently failing: https://github.com/dotnet/corefx/issues/31962 -->
-    <Configurations>netcoreapp-Debug;netcoreapp-Release;netfx-Debug;netfx-Release<!-- ;uap-Debug;uap-Release --></Configurations>
+    <Configurations>netcoreapp-Debug;netcoreapp-Release;netfx-Debug;netfx-Release</Configurations>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="..\..\Common\src\Interop\Windows\Interop.Libraries.cs">