Make variables private instead of protected

diff --git a/atom/browser/api/atom_api_menu_mac.h b/atom/browser/api/atom_api_menu_mac.h
index 7c41cd7..bc70e5b 100644 (file)
--- a/atom/browser/api/atom_api_menu_mac.h
+++ b/atom/browser/api/atom_api_menu_mac.h
@@ -29,14 +29,16 @@ class MenuMac : public Menu {
                  bool async);
   void ClosePopupAt(int32_t window_id) override;
 
-  scoped_nsobject<AtomMenuController> menu_controller_;
-  std::map<int32_t, scoped_nsobject<AtomMenuController>> popup_controllers_;
-
  private:
   friend class Menu;
 
   static void SendActionToFirstResponder(const std::string& action);
 
+  scoped_nsobject<AtomMenuController> menu_controller_;
+
+  // window ID -> open context menu
+  std::map<int32_t, scoped_nsobject<AtomMenuController>> popup_controllers_;
+
   base::WeakPtrFactory<MenuMac> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuMac);

diff --git a/atom/browser/api/atom_api_menu_views.h b/atom/browser/api/atom_api_menu_views.h
index f59e9d5..a974f75 100644 (file)
--- a/atom/browser/api/atom_api_menu_views.h
+++ b/atom/browser/api/atom_api_menu_views.h
@@ -26,7 +26,9 @@ class MenuViews : public Menu {
   void ClosePopupAt(int32_t window_id) override;
 
  private:
+  // window ID -> open context menu
   std::map<int32_t, std::unique_ptr<views::MenuRunner>> menu_runners_;
+
   base::WeakPtrFactory<MenuViews> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuViews);