keep the double quotes, but don't escape them
authorFlavio Curella <flavio.curella@gmail.com>
Mon, 1 Jul 2013 20:48:48 +0000 (15:48 -0500)
committerFlavio Curella <flavio.curella@gmail.com>
Mon, 1 Jul 2013 20:48:48 +0000 (15:48 -0500)
requests/cookies.py
test_requests.py

index a12feb562afa8faa4324b9f299f71d95d5982b77..d1e5d75b2520fc1ba5e5001dafe7c81b9502f32e 100644 (file)
@@ -261,7 +261,7 @@ class RequestsCookieJar(cookielib.CookieJar, collections.MutableMapping):
 
     def set_cookie(self, cookie, *args, **kwargs):
         if cookie.value.startswith('"') and cookie.value.endswith('"'):
-            cookie.value = cookie.value.strip('\\"')
+            cookie.value = cookie.value.replace('\\"', '')
         return super(RequestsCookieJar, self).set_cookie(cookie, *args, **kwargs)
 
     def update(self, other):
index b0e99c77fecdfc077e20f0b71ae4c02597ebaf51..e22b6ae3daeb5c448a0bbd3d7df49be6f4016385 100755 (executable)
@@ -173,7 +173,7 @@ class RequestsTestCase(unittest.TestCase):
     def test_cookie_quote_wrapped(self):
         s = requests.session()
         s.get(httpbin('cookies/set?foo="bar:baz"'))
-        self.assertTrue(s.cookies['foo'] == 'bar:baz')
+        self.assertTrue(s.cookies['foo'] == '"bar:baz"')
 
     def test_request_cookie_overrides_session_cookie(self):
         s = requests.session()