[media] imon: Improve a size determination in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 29 Aug 2017 10:45:59 +0000 (07:45 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 4 Oct 2017 19:19:40 +0000 (16:19 -0300)
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/rc/imon.c

index b83ad6d..9724fe8 100644 (file)
@@ -602,8 +602,7 @@ static int send_packet(struct imon_context *ictx)
                ictx->tx_urb->actual_length = 0;
        } else {
                /* fill request into kmalloc'ed space: */
-               control_req = kmalloc(sizeof(struct usb_ctrlrequest),
-                                     GFP_KERNEL);
+               control_req = kmalloc(sizeof(*control_req), GFP_KERNEL);
                if (control_req == NULL)
                        return -ENOMEM;
 
@@ -2310,7 +2309,7 @@ static struct imon_context *imon_init_intf0(struct usb_interface *intf,
        struct usb_host_interface *iface_desc;
        int ret = -ENOMEM;
 
-       ictx = kzalloc(sizeof(struct imon_context), GFP_KERNEL);
+       ictx = kzalloc(sizeof(*ictx), GFP_KERNEL);
        if (!ictx)
                goto exit;