media: lirc_zilog: Clean up lirc zilog error codes
authorYves Lemée <yves.lemee.kernel@gmail.com>
Wed, 12 Jul 2017 19:17:37 +0000 (15:17 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 13:47:28 +0000 (09:47 -0400)
According the coding style guidelines, the ENOSYS error code must be
returned in case of a non existent system call. This code has been
replaced with the ENOTTY error code indicating a missing functionality.

Signed-off-by: Yves Lemée <yves.lemee.kernel@gmail.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/lirc/lirc_zilog.c

index 015e41b..26dd32d 100644 (file)
@@ -1249,7 +1249,7 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
                break;
        case LIRC_GET_REC_MODE:
                if (!(features & LIRC_CAN_REC_MASK))
-                       return -ENOSYS;
+                       return -ENOTTY;
 
                result = put_user(LIRC_REC2MODE
                                  (features & LIRC_CAN_REC_MASK),
@@ -1257,21 +1257,21 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
                break;
        case LIRC_SET_REC_MODE:
                if (!(features & LIRC_CAN_REC_MASK))
-                       return -ENOSYS;
+                       return -ENOTTY;
 
                result = get_user(mode, uptr);
                if (!result && !(LIRC_MODE2REC(mode) & features))
-                       result = -EINVAL;
+                       result = -ENOTTY;
                break;
        case LIRC_GET_SEND_MODE:
                if (!(features & LIRC_CAN_SEND_MASK))
-                       return -ENOSYS;
+                       return -ENOTTY;
 
                result = put_user(LIRC_MODE_PULSE, uptr);
                break;
        case LIRC_SET_SEND_MODE:
                if (!(features & LIRC_CAN_SEND_MASK))
-                       return -ENOSYS;
+                       return -ENOTTY;
 
                result = get_user(mode, uptr);
                if (!result && mode != LIRC_MODE_PULSE)