Disable more SendPacketsElement tests on Win11 (#59359)
authorAnton Firszov <Anton.Firszov@microsoft.com>
Thu, 23 Sep 2021 12:48:47 +0000 (14:48 +0200)
committerGitHub <noreply@github.com>
Thu, 23 Sep 2021 12:48:47 +0000 (14:48 +0200)
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendPacketsAsync.cs

index 220d088..65764b4 100644 (file)
@@ -527,7 +527,10 @@ namespace System.Net.Sockets.Tests
             }
         }
 
-        [Fact]
+        public static bool IsNotWindows11 = !PlatformDetection.IsWindows10Version22000OrGreater;
+
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
+        [ConditionalFact(nameof(IsNotWindows11))]
         public void SendPacketsElement_FileStreamLargeOffset_Throws()
         {
             using (var stream = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.Read, 4096, useAsync: true))
@@ -550,7 +553,8 @@ namespace System.Net.Sockets.Tests
             }
         }
 
-        [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
+        [ConditionalFact(nameof(IsNotWindows11))]
         public void SendPacketsElement_FileStreamWithOptions_Success() {
             using (var stream = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, 4096, FileOptions.Asynchronous | FileOptions.SequentialScan)) {
                 var element = new SendPacketsElement(stream, 0, s_testFileSize);
@@ -581,15 +585,9 @@ namespace System.Net.Sockets.Tests
             }
         }
 
-        [ConditionalFact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
+        [ConditionalFact(nameof(IsNotWindows11))]
         public void SendPacketsElement_FileStreamMultiPartMixed_MultipleFileStreams_Success() {
-            
-            if (PlatformDetection.IsWindows10Version22000OrGreater)
-            {
-                // [ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
-                throw new SkipTestException("Unstable on Windows 11");
-            }
-
             using (var stream = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.Read, 4096, FileOptions.Asynchronous))
             using (var stream2 = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.Read, 4096, FileOptions.Asynchronous)) {
                 var elements = new[]