accel/habanalabs: improve readability of engines idle mask print

Remove leading zeroes when printing the idle mask to make it clearer.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c
index a5f5ee1..e544d00 100644 (file)
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -380,18 +380,17 @@ bool hl_ctrl_device_operational(struct hl_device *hdev,
 static void print_idle_status_mask(struct hl_device *hdev, const char *message,
                                        u64 idle_mask[HL_BUSY_ENGINES_MASK_EXT_SIZE])
 {
-       u32 pad_width[HL_BUSY_ENGINES_MASK_EXT_SIZE] = {};
-
-       BUILD_BUG_ON(HL_BUSY_ENGINES_MASK_EXT_SIZE != 4);
-
-       pad_width[3] = idle_mask[3] ? 16 : 0;
-       pad_width[2] = idle_mask[2] || pad_width[3] ? 16 : 0;
-       pad_width[1] = idle_mask[1] || pad_width[2] ? 16 : 0;
-       pad_width[0] = idle_mask[0] || pad_width[1] ? 16 : 0;
-
-       dev_err(hdev->dev, "%s (mask %0*llx_%0*llx_%0*llx_%0*llx)\n",
-               message, pad_width[3], idle_mask[3], pad_width[2], idle_mask[2],
-               pad_width[1], idle_mask[1], pad_width[0], idle_mask[0]);
+       if (idle_mask[3])
+               dev_err(hdev->dev, "%s (mask %#llx_%016llx_%016llx_%016llx)\n",
+                       message, idle_mask[3], idle_mask[2], idle_mask[1], idle_mask[0]);
+       else if (idle_mask[2])
+               dev_err(hdev->dev, "%s (mask %#llx_%016llx_%016llx)\n",
+                       message, idle_mask[2], idle_mask[1], idle_mask[0]);
+       else if (idle_mask[1])
+               dev_err(hdev->dev, "%s (mask %#llx_%016llx)\n",
+                       message, idle_mask[1], idle_mask[0]);
+       else
+               dev_err(hdev->dev, "%s (mask %#llx)\n", message, idle_mask[0]);
 }
 
 static void hpriv_release(struct kref *ref)