mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue
authorIdo Schimmel <idosch@mellanox.com>
Wed, 10 Apr 2019 06:58:13 +0000 (06:58 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Apr 2019 18:57:07 +0000 (11:57 -0700)
The EMAD workqueue is used to handle retransmission of EMAD packets that
contain configuration data for the device's firmware.

Given the workers need to allocate these packets and that the code is
not called as part of memory reclaim path, remove the WQ_MEM_RECLAIM
flag.

Fixes: d965465b60ba ("mlxsw: core: Fix possible deadlock")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c

index d23d53c0e2842bc0e28a179d3ef6457a3369cee7..91cd6fa42e9a3318b7d14aa80d81ad00df9ed082 100644 (file)
@@ -568,7 +568,7 @@ static int mlxsw_emad_init(struct mlxsw_core *mlxsw_core)
        if (!(mlxsw_core->bus->features & MLXSW_BUS_F_TXRX))
                return 0;
 
-       emad_wq = alloc_workqueue("mlxsw_core_emad", WQ_MEM_RECLAIM, 0);
+       emad_wq = alloc_workqueue("mlxsw_core_emad", 0, 0);
        if (!emad_wq)
                return -ENOMEM;
        mlxsw_core->emad_wq = emad_wq;