hwrng: exynos - Signedness bug in exynos_trng_do_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 10 Jan 2018 09:36:58 +0000 (12:36 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 18 Jan 2018 11:52:26 +0000 (22:52 +1100)
"val" needs to be signed for the error handling to work.

Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Ɓukasz Stelmach <l.stelmach@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/exynos-trng.c

index 34d6f51..f4643e3 100644 (file)
@@ -55,7 +55,7 @@ static int exynos_trng_do_read(struct hwrng *rng, void *data, size_t max,
                               bool wait)
 {
        struct exynos_trng_dev *trng;
-       u32 val;
+       int val;
 
        max = min_t(size_t, max, (EXYNOS_TRNG_FIFO_LEN * 4));