xvimagesink: fix leak when images are freed after the X context
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Fri, 13 Jan 2012 16:52:23 +0000 (16:52 +0000)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Fri, 13 Jan 2012 16:52:23 +0000 (16:52 +0000)
I'm not 100% sure this is valid on any other X server than mine,
but since the XFree call does not take the context as a parameter,
it seems pretty certain it's the right thing to do, but I'll put
this caveat here in case someone checks in the future.

sys/xvimage/xvimagesink.c

index 8a7913b6ac9fe4e46a8acd49ed0c4eaede36f3c0..0c386c161ecaae69ba0bc58ead03406a5ac8396f 100644 (file)
@@ -244,6 +244,8 @@ gst_xvimage_buffer_destroy (GstXvImageBuffer * xvimage)
       shmdt (xvimage->SHMInfo.shmaddr);
     }
 #endif
+    if (xvimage->xvimage)
+      XFree (xvimage->xvimage);
     goto beach;
   }