[ASan] Fix __asan_describe_address and add a test for it.
authorAlexey Samsonov <vonosmas@gmail.com>
Mon, 21 Jul 2014 21:33:46 +0000 (21:33 +0000)
committerAlexey Samsonov <vonosmas@gmail.com>
Mon, 21 Jul 2014 21:33:46 +0000 (21:33 +0000)
llvm-svn: 213583

compiler-rt/lib/asan/asan_report.cc
compiler-rt/test/asan/TestCases/describe_address.cc [new file with mode: 0644]

index 3135e10..395cefe 100644 (file)
@@ -945,7 +945,10 @@ void NOINLINE __asan_set_error_report_callback(void (*callback)(const char*)) {
 }
 
 void __asan_describe_address(uptr addr) {
+  // Thread registry must be locked while we're describing an address.
+  asanThreadRegistry().Lock();
   DescribeAddress(addr, 1);
+  asanThreadRegistry().Unlock();
 }
 
 extern "C" {
diff --git a/compiler-rt/test/asan/TestCases/describe_address.cc b/compiler-rt/test/asan/TestCases/describe_address.cc
new file mode 100644 (file)
index 0000000..868c0eb
--- /dev/null
@@ -0,0 +1,19 @@
+// RUN: %clangxx_asan -O0 %s -o %t && %run %t 2>&1 | FileCheck %s
+
+#include <sanitizer/asan_interface.h>
+
+int global;
+
+int main(int argc, char *argv[]) {
+  int stack;
+  int *heap = new int[100];
+  __asan_describe_address(heap);
+  // CHECK: {{.*}} is located 0 bytes inside of 400-byte region
+  // CHECK: allocated by thread T{{.*}} here
+  __asan_describe_address(&stack);
+  // CHECK: Address {{.*}} is located in stack of thread T{{.*}} at offset {{.*}}
+  __asan_describe_address(&global);
+  // CHECK: {{.*}} is located 0 bytes inside of global variable 'global'
+  delete[] heap;
+  return 0;
+}