Fix unit tests
authorBernd Weimer <bweimer@blackberry.com>
Mon, 31 Mar 2014 14:18:23 +0000 (16:18 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Wed, 2 Apr 2014 16:20:55 +0000 (18:20 +0200)
Random playback mode is not good for testing index changed signal,
because the same media might be played successively.
Calling show() might result in showFullScreen() on some platforms,
which is not expected by some video widget tests.

Change-Id: Ib47433fc6411b6dfa244a245aae508df5627ec62
Reviewed-by: Yoann Lopes <yoann.lopes@digia.com>
tests/auto/unit/qmediaplaylistnavigator/tst_qmediaplaylistnavigator.cpp
tests/auto/unit/qvideowidget/tst_qvideowidget.cpp

index b0f7d8b..1992dbc 100644 (file)
@@ -413,8 +413,7 @@ void tst_QMediaPlaylistNavigator::testCurrentIndexChangedSignal()
 {
     QMediaNetworkPlaylistProvider playlist;
     QMediaPlaylistNavigator navigator(&playlist);
-    navigator.setPlaybackMode(QMediaPlaylist::Random);
-    QCOMPARE(navigator.playbackMode(), QMediaPlaylist::Random);
+    QCOMPARE(navigator.playbackMode(), QMediaPlaylist::Sequential);
     QCOMPARE(navigator.currentIndex(), -1);
 
     //Creating a QSignalSpy object for currentIndexChanged() signal
index c6c9bc1..23e5699 100644 (file)
@@ -907,7 +907,7 @@ void tst_QVideoWidget::fullScreenWindowControl()
     QtTestVideoObject object(new QtTestWindowControl, 0, 0);
     QVideoWidget widget;
     object.bind(&widget);
-    widget.show();
+    widget.showNormal();
     QVERIFY(QTest::qWaitForWindowExposed(&widget));
 
     Qt::WindowFlags windowFlags = widget.windowFlags();
@@ -992,7 +992,7 @@ void tst_QVideoWidget::fullScreenWidgetControl()
     QtTestVideoObject object(0, new QtTestWidgetControl, 0);
     QVideoWidget widget;
     object.bind(&widget);
-    widget.show();
+    widget.showNormal();
     QVERIFY(QTest::qWaitForWindowExposed(&widget));
 
     Qt::WindowFlags windowFlags = widget.windowFlags();
@@ -1078,7 +1078,7 @@ void tst_QVideoWidget::fullScreenRendererControl()
     QtTestVideoObject object(0, 0, new QtTestRendererControl);
     QVideoWidget widget;
     object.bind(&widget);
-    widget.show();
+    widget.showNormal();
     QVERIFY(QTest::qWaitForWindowExposed(&widget));
 
     Qt::WindowFlags windowFlags = widget.windowFlags();