[media] drivers/media/rc/ati_remote.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 4 Sep 2012 11:05:04 +0000 (08:05 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 23 Sep 2012 16:42:45 +0000 (13:42 -0300)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/ati_remote.c

index 08aede5..49bb356 100644 (file)
@@ -937,8 +937,10 @@ static int ati_remote_probe(struct usb_interface *interface,
        /* Set up and register mouse input device */
        if (mouse) {
                input_dev = input_allocate_device();
-               if (!input_dev)
+               if (!input_dev) {
+                       err = -ENOMEM;
                        goto fail4;
+               }
 
                ati_remote->idev = input_dev;
                ati_remote_input_init(ati_remote);