projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5e9c523
)
spi: spi-cavium-thunderx: Add missing pci_release_regions()
author
Chuhong Yuan
<hslester96@gmail.com>
Fri, 6 Dec 2019 07:55:00 +0000
(15:55 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 9 Dec 2019 18:44:19 +0000
(18:44 +0000)
The driver forgets to call pci_release_regions() in probe failure
and remove.
Add the missed calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link:
https://lore.kernel.org/r/20191206075500.18525-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cavium-thunderx.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-cavium-thunderx.c
b/drivers/spi/spi-cavium-thunderx.c
index
d12e149
..
fd6b9ca
100644
(file)
--- a/
drivers/spi/spi-cavium-thunderx.c
+++ b/
drivers/spi/spi-cavium-thunderx.c
@@
-82,6
+82,7
@@
static int thunderx_spi_probe(struct pci_dev *pdev,
error:
clk_disable_unprepare(p->clk);
+ pci_release_regions(pdev);
spi_master_put(master);
return ret;
}
@@
-96,6
+97,7
@@
static void thunderx_spi_remove(struct pci_dev *pdev)
return;
clk_disable_unprepare(p->clk);
+ pci_release_regions(pdev);
/* Put everything in a known state. */
writeq(0, p->register_base + OCTEON_SPI_CFG(p));
}