net/devlink: Prepare devlink port functions to fill extack
authorParav Pandit <parav@mellanox.com>
Fri, 19 Jun 2020 03:32:47 +0000 (03:32 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Jun 2020 22:29:18 +0000 (15:29 -0700)
Prepare devlink port related functions to optionally fill up
the extack information which will be used in subsequent patch by port
function attribute(s).

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c

index 2cafbc8..0519763 100644 (file)
@@ -566,7 +566,8 @@ static int devlink_nl_port_attrs_put(struct sk_buff *msg,
 static int devlink_nl_port_fill(struct sk_buff *msg, struct devlink *devlink,
                                struct devlink_port *devlink_port,
                                enum devlink_command cmd, u32 portid,
-                               u32 seq, int flags)
+                               u32 seq, int flags,
+                               struct netlink_ext_ack *extack)
 {
        void *hdr;
 
@@ -634,7 +635,8 @@ static void devlink_port_notify(struct devlink_port *devlink_port,
        if (!msg)
                return;
 
-       err = devlink_nl_port_fill(msg, devlink, devlink_port, cmd, 0, 0, 0);
+       err = devlink_nl_port_fill(msg, devlink, devlink_port, cmd, 0, 0, 0,
+                                  NULL);
        if (err) {
                nlmsg_free(msg);
                return;
@@ -708,7 +710,8 @@ static int devlink_nl_cmd_port_get_doit(struct sk_buff *skb,
 
        err = devlink_nl_port_fill(msg, devlink, devlink_port,
                                   DEVLINK_CMD_PORT_NEW,
-                                  info->snd_portid, info->snd_seq, 0);
+                                  info->snd_portid, info->snd_seq, 0,
+                                  info->extack);
        if (err) {
                nlmsg_free(msg);
                return err;
@@ -740,7 +743,8 @@ static int devlink_nl_cmd_port_get_dumpit(struct sk_buff *msg,
                                                   DEVLINK_CMD_NEW,
                                                   NETLINK_CB(cb->skb).portid,
                                                   cb->nlh->nlmsg_seq,
-                                                  NLM_F_MULTI);
+                                                  NLM_F_MULTI,
+                                                  cb->extack);
                        if (err) {
                                mutex_unlock(&devlink->lock);
                                goto out;