pngdec: Stop trying to decode once inflate returns Z_STREAM_END
authorMartin Storsjö <martin@martin.st>
Sat, 28 Sep 2013 21:12:04 +0000 (00:12 +0300)
committerMartin Storsjö <martin@martin.st>
Sun, 29 Sep 2013 17:01:03 +0000 (20:01 +0300)
If the input buffer contains more data after the deflate stream,
the loop previously left running infinitely, with inflate returning
Z_STREAM_END.

Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>
libavcodec/pngdec.c

index ec44d56..8864e4a 100644 (file)
@@ -378,6 +378,10 @@ static int png_decode_idat(PNGDecContext *s, int length)
             s->zstream.avail_out = s->crow_size;
             s->zstream.next_out  = s->crow_buf;
         }
+        if (ret == Z_STREAM_END && s->zstream.avail_in > 0) {
+            av_log(NULL, AV_LOG_WARNING, "%d undecompressed bytes left in buffer\n", s->zstream.avail_in);
+            return 0;
+        }
     }
     return 0;
 }