Remove redundant Begin/End form signpost format strings.
authorAdrian Prantl <aprantl@apple.com>
Thu, 3 Jun 2021 18:22:24 +0000 (11:22 -0700)
committerAdrian Prantl <aprantl@apple.com>
Thu, 3 Jun 2021 18:24:13 +0000 (11:24 -0700)
The os_signpost API already captures the begin/end part and in
Instruments, this just adds visual noise that gets in the way of the
interesting data. By removing the redundant end text, the display in
Instruments gets even less cluttered.

rdar://78636200

Differential Revision: https://reviews.llvm.org/D103577

llvm/lib/Support/Signposts.cpp

index 37e16a9..7bf7b46 100644 (file)
@@ -74,7 +74,7 @@ public:
       if (SIGNPOSTS_AVAILABLE()) {
         // Both strings used here are required to be constant literal strings.
         os_signpost_interval_begin(getLogger(), getSignpostForObject(O),
-                                   "LLVM Timers", "Begin %s", Name.data());
+                                   "LLVM Timers", "%s", Name.data());
       }
     }
   }
@@ -84,7 +84,7 @@ public:
       if (SIGNPOSTS_AVAILABLE()) {
         // Both strings used here are required to be constant literal strings.
         os_signpost_interval_end(getLogger(), getSignpostForObject(O),
-                                 "LLVM Timers", "End %s", Name.data());
+                                 "LLVM Timers", "");
       }
     }
   }