usb: musb: cppi41: Switch to use dev_err_probe() helper

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-4-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
index c963cb8..9589243 100644 (file)
--- a/drivers/usb/musb/musb_cppi41.c
+++ b/drivers/usb/musb/musb_cppi41.c
@@ -718,10 +718,8 @@ static int cppi41_dma_controller_start(struct cppi41_dma_controller *controller)
 
                dc = dma_request_chan(dev->parent, str);
                if (IS_ERR(dc)) {
-                       ret = PTR_ERR(dc);
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(dev, "Failed to request %s: %d.\n",
-                                       str, ret);
+                       ret = dev_err_probe(dev, PTR_ERR(dc),
+                                           "Failed to request %s.\n", str);
                        goto err;
                }