ARM: dts: BCM53573: Fix Ethernet info for Luxul devices
authorRafał Miłecki <rafal@milecki.pl>
Thu, 13 Jul 2023 11:11:45 +0000 (13:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:42:40 +0000 (09:42 +0200)
[ Upstream commit 44ad8207806973f4e4f7d870fff36cc01f494250 ]

Both Luxul's XAP devices (XAP-810 and XAP-1440) are access points that
use a non-default design. They don't include switch but have a single
Ethernet port and BCM54210E PHY connected to the Ethernet controller's
MDIO bus.

Support for those devices regressed due to two changes:

1. Describing MDIO bus with switch
After commit 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125
rev 4 switch") Linux stopped probing for MDIO devices.

2. Dropping hardcoded BCM54210E delays
In commit fea7fda7f50a ("net: phy: broadcom: Fix RGMII delays
configuration for BCM54210E") support for other PHY modes was added but
that requires a proper "phy-mode" value in DT.

Both above changes are correct (they don't need to be reverted or
anything) but they need this fix for DT data to be correct and for Linux
to work properly.

Fixes: 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125 rev 4 switch")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Link: https://lore.kernel.org/r/20230713111145.14864-1-zajec5@gmail.com
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts
arch/arm/boot/dts/bcm47189-luxul-xap-810.dts

index e20b6d2eb274ac4bdc2629d8ad2e3e238c37beba..1e23e0a807819ac0dd1e63cc2eb4e61525ee128c 100644 (file)
                };
        };
 };
+
+&gmac0 {
+       phy-mode = "rgmii";
+       phy-handle = <&bcm54210e>;
+
+       mdio {
+               /delete-node/ switch@1e;
+
+               bcm54210e: ethernet-phy@0 {
+                       reg = <0>;
+               };
+       };
+};
index 9d863570fcf3ae7e258e298a212e260e1e420af4..5dbb950c8113e6e7d71bd8b35e7261b7317e4cb3 100644 (file)
                };
        };
 };
+
+&gmac0 {
+       phy-mode = "rgmii";
+       phy-handle = <&bcm54210e>;
+
+       mdio {
+               /delete-node/ switch@1e;
+
+               bcm54210e: ethernet-phy@0 {
+                       reg = <0>;
+               };
+       };
+};