Correct comments in x86_64/multiarch/memcmp.S
authorH.J. Lu <hjl.tools@gmail.com>
Thu, 18 May 2017 21:02:02 +0000 (14:02 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Thu, 18 May 2017 21:02:02 +0000 (14:02 -0700)
* sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct
comments.

ChangeLog
sysdeps/x86_64/multiarch/memcmp.S

index 06ef5789b0bc3aacde09079e757af06a0b3a0178..5ebd3a04abce97649186230333765d38121baef8 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-18  H.J. Lu  <hongjiu.lu@intel.com>
+
+       * sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct
+       comments.
+
 2017-05-18  Siddhesh Poyarekar  <siddhesh@sourceware.org>
 
        * elf/Makefile (tst-env-setuid-ENV): Reduce value of
index 82623173d68dddcba0ebd5a5e931b3c8163e67d8..61298200931a1abe75d105ac551ccf0c199332e9 100644 (file)
@@ -56,9 +56,9 @@ END(memcmp)
 
 # ifdef SHARED
 #  undef libc_hidden_builtin_def
-/* IFUNC doesn't work with the hidden functions in shared library since
-   they will be called without setting up EBX needed for PLT which is
-   used by IFUNC.  */
+/* It doesn't make sense to send libc-internal memcmp calls through a PLT.
+   The speedup we get from using SSE4 instructions is likely eaten away
+   by the indirect call in the PLT.  */
 #  define libc_hidden_builtin_def(name) \
        .globl __GI_memcmp; __GI_memcmp = __memcmp_sse2
 # endif