devres: No need to call remove_nodes() when there none present
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 17 May 2021 12:29:45 +0000 (15:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Jun 2021 15:14:36 +0000 (17:14 +0200)
If a list of devres nodes is empty, no need to call remove_nodes().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210517122946.53161-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devres.c

index db1f313..dee4885 100644 (file)
@@ -526,6 +526,10 @@ int devres_release_all(struct device *dev)
        if (WARN_ON(dev->devres_head.next == NULL))
                return -ENODEV;
 
+       /* Nothing to release if list is empty */
+       if (list_empty(&dev->devres_head))
+               return 0;
+
        spin_lock_irqsave(&dev->devres_lock, flags);
        cnt = remove_nodes(dev, dev->devres_head.next, &dev->devres_head, &todo);
        spin_unlock_irqrestore(&dev->devres_lock, flags);