projects
/
sdk
/
emulator
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0fdc9aa
)
hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes
author
Peter Maydell
<peter.maydell@linaro.org>
Wed, 9 Nov 2011 17:42:23 +0000
(17:42 +0000)
committer
Anthony Liguori
<aliguori@us.ibm.com>
Wed, 9 Nov 2011 18:06:20 +0000
(12:06 -0600)
Add missing 'break' statements which would have meant that writing
to an 8 bit NAND device was broken. Spotted by Coverity (see bug
887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/omap_gpmc.c
patch
|
blob
|
history
diff --git
a/hw/omap_gpmc.c
b/hw/omap_gpmc.c
index 7fc82a252691d602765dbcc6bb7b4df17cdb989f..414f9f5c375594064913872e2dd37e64f0136f32 100644
(file)
--- a/
hw/omap_gpmc.c
+++ b/
hw/omap_gpmc.c
@@
-180,6
+180,7
@@
static void omap_nand_setio(DeviceState *dev, uint64_t value,
nand_setio(dev, (value >> 24) & 0xff);
break;
}
+ break;
case OMAP_GPMC_16BIT:
switch (size) {
case 1:
@@
-195,6
+196,7
@@
static void omap_nand_setio(DeviceState *dev, uint64_t value,
nand_setio(dev, (value >> 16) & 0xffff);
break;
}
+ break;
}
}