staging: ccree: Fix unnecessary NULL check before kfree'ing it
authorSuniel Mahesh <sunil.m@techveda.org>
Thu, 20 Jul 2017 13:37:07 +0000 (19:07 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Jul 2017 04:55:24 +0000 (21:55 -0700)
kfree(NULL) is safe and their is no need for a NULL check. Pointed out
by checkpatch.

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_hash.c

index 7fd3c3c..1a405bb 100644 (file)
@@ -297,20 +297,14 @@ fail2:
 fail1:
         kfree(state->digest_buff);
 fail_digest_result_buff:
-        if (state->digest_result_buff) {
-                kfree(state->digest_result_buff);
-            state->digest_result_buff = NULL;
-        }
+       kfree(state->digest_result_buff);
+       state->digest_result_buff = NULL;
 fail_buff1:
-        if (state->buff1) {
-                kfree(state->buff1);
-            state->buff1 = NULL;
-        }
+       kfree(state->buff1);
+       state->buff1 = NULL;
 fail_buff0:
-        if (state->buff0) {
-                kfree(state->buff0);
-            state->buff0 = NULL;
-        }
+       kfree(state->buff0);
+       state->buff0 = NULL;
 fail0:
        return rc;
 }
@@ -2326,11 +2320,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
        return 0;
 
 fail:
-
-       if (drvdata->hash_handle) {
-               kfree(drvdata->hash_handle);
-               drvdata->hash_handle = NULL;
-       }
+       kfree(drvdata->hash_handle);
+       drvdata->hash_handle = NULL;
        return rc;
 }