mmc: sdhci-of-aspeed: Turn down a phase correction warning
authorAndrew Jeffery <andrew@aj.id.au>
Mon, 7 Jun 2021 01:30:20 +0000 (11:00 +0930)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 14 Jun 2021 11:57:44 +0000 (13:57 +0200)
The card timing and the bus frequency are not changed atomically with
respect to calls to the set_clock() callback in the driver. The result
is the driver sees a transient state where there's a mismatch between
the two and thus the inputs to the phase correction calculation
formula are garbage.

Switch from dev_warn() to dev_dbg() to avoid noise in the normal case,
though the change does make bad configurations less likely to be
noticed.

Reported-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20210607013020.85885-1-andrew@aj.id.au
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-of-aspeed.c

index 65b5685..6e4e132 100644 (file)
@@ -186,7 +186,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz,
 
        tap = div_u64(phase_period_ps, prop_delay_ps);
        if (tap > ASPEED_SDHCI_NR_TAPS) {
-               dev_warn(dev,
+               dev_dbg(dev,
                         "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n",
                         tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS);
                tap = ASPEED_SDHCI_NR_TAPS;