arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
authorRobin Murphy <robin.murphy@arm.com>
Sat, 16 Nov 2019 12:47:19 +0000 (12:47 +0000)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 9 Dec 2019 08:44:21 +0000 (09:44 +0100)
Although it appeared to follow logically from the bindings, apparently
the thermal framework can't properly cope with a single cooling device
being shared between multiple maps. The CPU zone is probably easier to
overheat, so remove the references to the (optional) fan from the GPU
cooling zone to avoid things getting confused. Hopefully GPU-intensive
tasks will leak enough heat across to the CPU zone to still hit the
fan trips before reaching critical GPU temperatures.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/5bb39f3115df1a487d717d3ae87e523b03749379.1573908197.git.robin.murphy@arm.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts

index 2a12798..d3ed8e5 100644 (file)
        };
 };
 
-&gpu_thermal {
-       trips {
-               gpu_warm: gpu_warm {
-                       temperature = <55000>;
-                       hysteresis = <2000>;
-                       type = "active";
-               };
-
-               gpu_hot: gpu_hot {
-                       temperature = <65000>;
-                       hysteresis = <2000>;
-                       type = "active";
-               };
-       };
-       cooling-maps {
-               map1 {
-                       trip = <&gpu_warm>;
-                       cooling-device = <&fan THERMAL_NO_LIMIT 1>;
-               };
-
-               map2 {
-                       trip = <&gpu_hot>;
-                       cooling-device = <&fan 2 THERMAL_NO_LIMIT>;
-               };
-       };
-};
-
 &pinctrl {
        ir {
                ir_rx: ir-rx {