Fix override of common symbols for a.out
authorAlan Modra <amodra@gmail.com>
Fri, 12 Jan 2018 00:07:28 +0000 (10:37 +1030)
committerAlan Modra <amodra@gmail.com>
Fri, 12 Jan 2018 10:43:11 +0000 (21:13 +1030)
The default should be bfd_link_common_skip_none, as in the original
patch at https://sourceware.org/ml/binutils/2002-07/msg00717.html

* aoutx.h (aout_link_check_ar_symbols): Remove default and handle
bfd_link_common_skip_none in switch.

bfd/ChangeLog
bfd/aoutx.h

index 85ea86a..19364c0 100644 (file)
@@ -1,3 +1,8 @@
+2018-01-12  Gunther Nikl  <gnikl@users.sourceforge.net>
+
+       * aoutx.h (aout_link_check_ar_symbols): Remove default and handle
+       bfd_link_common_skip_none in switch.
+
 2018-01-12  Alan Modra  <amodra@gmail.com>
 
        PR ld/22649
index 6dc4c68..eec9c4a 100644 (file)
@@ -3366,13 +3366,14 @@ aout_link_check_ar_symbols (bfd *abfd,
 
              switch (info->common_skip_ar_symbols)
                {
+               case bfd_link_common_skip_none:
+                 break;
                case bfd_link_common_skip_text:
                  skip = (type == (N_TEXT | N_EXT));
                  break;
                case bfd_link_common_skip_data:
                  skip = (type == (N_DATA | N_EXT));
                  break;
-               default:
                case bfd_link_common_skip_all:
                  skip = 1;
                  break;