crypto: ccp - Log when resetting PSP SEV state
authorPeter Gonda <pgonda@google.com>
Wed, 13 Apr 2022 15:58:35 +0000 (08:58 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 21 Apr 2022 09:53:55 +0000 (17:53 +0800)
Currently when the PSP returns a SECURE_DATA_INVALID error on INIT or
INIT_EX the driver retries the command once which should reset the PSP's
state SEV related state, meaning the PSP will regenerate its keying
material. This is logged with a dbg log but given this will change
system state this should be logged at a higher priority and with more
information.

Signed-off-by: Peter Gonda <pgonda@google.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: John Allen <john.allen@amd.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/sev-dev.c

index 6ab93df..fd92819 100644 (file)
@@ -435,7 +435,7 @@ static int __sev_platform_init_locked(int *error)
                 * initialization function should succeed by replacing the state
                 * with a reset state.
                 */
-               dev_dbg(sev->dev, "SEV: retrying INIT command");
+               dev_err(sev->dev, "SEV: retrying INIT command because of SECURE_DATA_INVALID error. Retrying once to reset PSP SEV state.");
                rc = init_function(&psp_ret);
        }
        if (error)