mxser: remove MOXA_ASPP_OQUEUE ioctl
authorJiri Slaby <jslaby@suse.cz>
Fri, 18 Jun 2021 06:14:35 +0000 (08:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jun 2021 11:10:00 +0000 (13:10 +0200)
1) The semantics are defined exactly nowhere.
2) The ioctl definition was never exposed to userspace, so noone should
   actually be reliably using this.
3) It's not even mentioned in any of the mxser utilities.

Provided the above, remove this mxser-special ioctl.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-30-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/mxser.c

index 1eb4814..ca417d9 100644 (file)
@@ -60,8 +60,6 @@
 #define RS485_4WIRE_MODE       3
 #define OP_MODE_MASK           3
 
-#define MOXA_ASPP_OQUEUE       (MOXA + 70)
-
 /* --------------------------------------------------- */
 
 /*
@@ -1499,17 +1497,6 @@ static int mxser_ioctl(struct tty_struct *tty,
                                mxser_cflags_changed(info, arg, &cnow));
        case MOXA_HighSpeedOn:
                return put_user(info->baud_base != 115200 ? 1 : 0, (int __user *)argp);
-       case MOXA_ASPP_OQUEUE:{
-               int len, lsr;
-
-               len = mxser_chars_in_buffer(tty);
-               spin_lock_irq(&info->slock);
-               lsr = inb(info->ioaddr + UART_LSR) & UART_LSR_THRE;
-               spin_unlock_irq(&info->slock);
-               len += (lsr ? 0 : 1);
-
-               return put_user(len, (int __user *)argp);
-       }
        default:
                return -ENOIOCTLCMD;
        }