We don't want to teach you bad habbits, so here's a fix for a memleak in the example...

Original commit message from CVS:
We don't want to teach you bad habbits, so here's a fix for a memleak in
the example plugin.

diff --git a/examples/plugins/example.c b/examples/plugins/example.c
index a2dad20..05db9b1 100644 (file)
--- a/examples/plugins/example.c
+++ b/examples/plugins/example.c
@@ -266,6 +266,10 @@ gst_example_chain (GstPad *pad, GstBuffer *buf)
     /* Then copy the data in the incoming buffer into the new buffer. */
     memcpy (GST_BUFFER_DATA (outbuf), GST_BUFFER_DATA (buf), GST_BUFFER_SIZE (outbuf));
 
+    /* we don't need the incomming buffer anymore so we unref it. When we are
+     * the last plugin with a handle to the buffer, its memory will be freed */
+    gst_buffer_unref (buf);
+
     /* When we're done with the buffer, we push it on to the next element
      * in the pipeline, through the element's source pad, which is stored
      * in the element's structure.

diff --git a/tests/old/examples/plugins/example.c b/tests/old/examples/plugins/example.c
index a2dad20..05db9b1 100644 (file)
--- a/tests/old/examples/plugins/example.c
+++ b/tests/old/examples/plugins/example.c
@@ -266,6 +266,10 @@ gst_example_chain (GstPad *pad, GstBuffer *buf)
     /* Then copy the data in the incoming buffer into the new buffer. */
     memcpy (GST_BUFFER_DATA (outbuf), GST_BUFFER_DATA (buf), GST_BUFFER_SIZE (outbuf));
 
+    /* we don't need the incomming buffer anymore so we unref it. When we are
+     * the last plugin with a handle to the buffer, its memory will be freed */
+    gst_buffer_unref (buf);
+
     /* When we're done with the buffer, we push it on to the next element
      * in the pipeline, through the element's source pad, which is stored
      * in the element's structure.