playback: element_init returns void

no need to return boolean as it will
be always TRUE.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1029>

diff --git a/gst/playback/gstplaybackelement.c b/gst/playback/gstplaybackelement.c
index 7ac053b5675d29e4cc93d188b439032f396d2dbd..8505fdfdecd070c99c842254d93f7e210b59b924 100644 (file)
--- a/gst/playback/gstplaybackelement.c
+++ b/gst/playback/gstplaybackelement.c
@@ -36,10 +36,11 @@
 #include "gstplaybackelements.h"
 
 
-gboolean
+void
 playback_element_init (GstPlugin * plugin)
 {
   static gsize res = FALSE;
+
   if (g_once_init_enter (&res)) {
     gst_pb_utils_init ();
 
@@ -51,5 +52,4 @@ playback_element_init (GstPlugin * plugin)
 #endif /* ENABLE_NLS */
     g_once_init_leave (&res, TRUE);
   }
-  return res;
 }

diff --git a/gst/playback/gstplaybackelements.h b/gst/playback/gstplaybackelements.h
index e08608df437bfc843c487c325e75cccac36d357e..51ddc0ccbb9b1812722ac92af0b81ca8965dd943 100644 (file)
--- a/gst/playback/gstplaybackelements.h
+++ b/gst/playback/gstplaybackelements.h
@@ -39,6 +39,6 @@ GST_ELEMENT_REGISTER_DECLARE (parsebin);
 gboolean gst_play_bin_custom_element_init (GstPlugin * plugin);
 gboolean gst_play_bin3_custom_element_init (GstPlugin * plugin);
 
-G_GNUC_INTERNAL gboolean playback_element_init (GstPlugin * plugin);
+G_GNUC_INTERNAL void playback_element_init (GstPlugin * plugin);
 
 #endif /* __GST_PLAY_BACK_ELEMENTS_H__ */

diff --git a/gst/playback/gstplaybin3.c b/gst/playback/gstplaybin3.c
index 753e12df8997fa6a264894a6a26b902a777d5061..60dd2afb230907ad41a1d41f86b56fa04c4bc966 100644 (file)
--- a/gst/playback/gstplaybin3.c
+++ b/gst/playback/gstplaybin3.c
@@ -5154,7 +5154,7 @@ gst_play_bin3_custom_element_init (GstPlugin * plugin)
 
   GST_DEBUG_CATEGORY_INIT (gst_play_bin3_debug, "playbin3", 0, "play bin3");
 
-  ret &= playback_element_init (plugin);
+  playback_element_init (plugin);
 
   if (g_getenv ("USE_PLAYBIN3"))
     ret &= gst_element_register (plugin, "playbin", GST_RANK_NONE,