gfx: drv: don't store meminfo handle on psbfb
authorAnder Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Wed, 15 Feb 2012 13:02:19 +0000 (15:02 +0200)
committerMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Tue, 3 Jul 2012 09:29:53 +0000 (12:29 +0300)
The handle has no reference count and might be freed by the client
before the psbfb is destroyed.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
drivers/staging/mrst/drv/psb_fb.c
drivers/staging/mrst/drv/psb_fb.h

index 5621db0..b437e84 100644 (file)
@@ -283,7 +283,6 @@ static struct drm_framebuffer *psb_user_framebuffer_create
 
        psbfb = to_psb_fb(fb);
        psbfb->size = sizes[0];
-       psbfb->hKernelMemInfo = hKernelMemInfo;
 
        DRM_DEBUG("Mapping to gtt..., KernelMemInfo %p\n", psKernelMemInfo);
 
index 5085f8b..f421030 100644 (file)
@@ -38,7 +38,6 @@ struct psb_framebuffer {
        struct fb_info * fbdev;
        /* struct ttm_bo_kmap_obj kmap; */
        PVRSRV_KERNEL_MEM_INFO *pvrBO;
-       IMG_HANDLE hKernelMemInfo;
        uint32_t size;
        uint32_t offset;
 };