Reimplement QAbstractSocket::setReadBufferSize() properly
authorBradley T. Hughes <bradley.hughes@nokia.com>
Thu, 2 Feb 2012 08:05:04 +0000 (09:05 +0100)
committerQt by Nokia <qt-info@nokia.com>
Thu, 2 Feb 2012 13:18:36 +0000 (14:18 +0100)
This function takes a qint64 argument, not an int argument.

peerwireclient.h:119:10: warning: 'PeerWireClient::setReadBufferSize'
     hides overloaded virtual function [-Woverloaded-virtual]
    void setReadBufferSize(int size);
         ^
src/network/socket/qabstractsocket.h:162:18: note: hidden overloaded
     virtual function 'QAbstractSocket::setReadBufferSize' declared here
    virtual void setReadBufferSize(qint64 size);
                 ^

Change-Id: I29b67b216147771ff2d662d309d2c31d977e9d3f
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
examples/network/torrent/peerwireclient.cpp
examples/network/torrent/peerwireclient.h

index b5819ad..c3d3779 100644 (file)
@@ -375,7 +375,7 @@ qint64 PeerWireClient::uploadSpeed() const
     return sum / (8 * 2);
 }
 
-void PeerWireClient::setReadBufferSize(int size)
+void PeerWireClient::setReadBufferSize(qint64 size)
 {
     socket.setReadBufferSize(size);
 }
index 369d841..2a6e965 100644 (file)
@@ -116,7 +116,7 @@ public:
     qint64 socketBytesAvailable() const { return socket.bytesAvailable(); }
     qint64 socketBytesToWrite() const { return socket.bytesToWrite(); }
 
-    void setReadBufferSize(int size);
+    void setReadBufferSize(qint64 size);
 
 signals:
     void infoHashReceived(const QByteArray &infoHash);