mwifiex: use is_broadcast_ether_addr() instead of memcmp()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 24 Aug 2012 05:25:30 +0000 (13:25 +0800)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 7 Sep 2012 19:03:38 +0000 (15:03 -0400)
Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/sta_cmd.c

index 0cc3406..3a4161c 100644 (file)
@@ -551,7 +551,6 @@ mwifiex_cmd_802_11_key_material(struct mwifiex_private *priv,
        struct host_cmd_tlv_mac_addr *tlv_mac;
        u16 key_param_len = 0, cmd_size;
        int ret = 0;
-       const u8 bc_mac[] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
 
        cmd->command = cpu_to_le16(HostCmd_CMD_802_11_KEY_MATERIAL);
        key_material->action = cpu_to_le16(cmd_action);
@@ -593,7 +592,7 @@ mwifiex_cmd_802_11_key_material(struct mwifiex_private *priv,
                        /* set 0 when re-key */
                        key_material->key_param_set.key[1] = 0;
 
-               if (0 != memcmp(enc_key->mac_addr, bc_mac, sizeof(bc_mac))) {
+               if (!is_broadcast_ether_addr(enc_key->mac_addr)) {
                        /* WAPI pairwise key: unicast */
                        key_material->key_param_set.key_info |=
                                cpu_to_le16(KEY_UNICAST);