HID: logitech-hidpp: Rename HID++ "internal" error constant
authorBastien Nocera <hadess@hadess.net>
Tue, 20 Jun 2023 08:50:14 +0000 (10:50 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 14 Aug 2023 09:22:26 +0000 (11:22 +0200)
As per the upstream "hidpp" helpers commit:
"
There has been some confusion about error value 5 but feature specs that
refer to it generally use NOT_ALLOWED.
"

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Link: https://github.com/mrubli2/hidpp/commit/80c3fecfcd89c5efe0f16feabe90a55ddfd25aaa
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c

index 129b01b..3f3ad6a 100644 (file)
@@ -228,7 +228,7 @@ struct hidpp_device {
 #define HIDPP20_ERROR_INVALID_ARGS             0x02
 #define HIDPP20_ERROR_OUT_OF_RANGE             0x03
 #define HIDPP20_ERROR_HW_ERROR                 0x04
-#define HIDPP20_ERROR_LOGITECH_INTERNAL                0x05
+#define HIDPP20_ERROR_NOT_ALLOWED              0x05
 #define HIDPP20_ERROR_INVALID_FEATURE_INDEX    0x06
 #define HIDPP20_ERROR_INVALID_FUNCTION_ID      0x07
 #define HIDPP20_ERROR_BUSY                     0x08