fix resource leak in RTSP_ERROR case

- add g_object_unref in RTSP_ERROR case.
- set wfd_msg to NULL after message_free for avoid double free
  in error case.

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: Ieab1eea9c33512bcc60d20666e6bd59ecdec2692

diff --git a/packaging/gst-plugins-tizen.spec b/packaging/gst-plugins-tizen.spec
index a50a2db393ee1f9845948abf45888c027561a163..7e171cfdfddd2456b06821e7f1ab1c94bac05ebf 100644 (file)
--- a/packaging/gst-plugins-tizen.spec
+++ b/packaging/gst-plugins-tizen.spec
@@ -9,7 +9,7 @@
 Name:       gst-plugins-tizen
 Version:    1.0.0
 Summary:    GStreamer tizen plugins (common)
-Release:    46
+Release:    47
 Group:      Multimedia/Framework
 Url:        http://gstreamer.freedesktop.org/
 License:    LGPL-2.1+

diff --git a/wfdmanager/wfdbase/gstwfdbasesrc.c b/wfdmanager/wfdbase/gstwfdbasesrc.c
index 16cf91f9de9f94ce8edbac6c1f12d127d5eaefe1..9de2017bef6557a6f7db325179fe1f448a08982a 100644 (file)
--- a/wfdmanager/wfdbase/gstwfdbasesrc.c
+++ b/wfdmanager/wfdbase/gstwfdbasesrc.c
@@ -944,6 +944,7 @@ gst_wfd_base_src_send_request (GstWFDBaseSrc * src)
   }
 
   gst_wfd_message_free (wfd_msg);
+  wfd_msg = NULL;
 
   /* send request message  */
   GST_DEBUG_OBJECT (src, "send reuest...");

diff --git a/wfdmanager/wfdsrc/gstwfdsrc.c b/wfdmanager/wfdsrc/gstwfdsrc.c
index b89c75f34c2e4be14e79bf490cb18d0e0c605880..b45cb870804ad36b273ecfc9d4a043c9d83e1e9e 100644 (file)
--- a/wfdmanager/wfdsrc/gstwfdsrc.c
+++ b/wfdmanager/wfdsrc/gstwfdsrc.c
@@ -1193,10 +1193,14 @@ gst_wfd_src_switch_tcp (GstWFDBaseSrc *bsrc)
 {
   GstRTSPResult res = GST_RTSP_OK;
   GstWFDSrc *src = GST_WFD_SRC (bsrc);
+  GCancellable *cancellable;
 
-  if (GST_RTSP_OK != gst_rtsp_connection_accept (src->tcp, &src->tcp_connection, g_cancellable_new())) {
+  cancellable = g_cancellable_new();
+
+  if (GST_RTSP_OK != gst_rtsp_connection_accept (src->tcp, &src->tcp_connection, cancellable)) {
     g_socket_close (src->tcp, NULL);
     GST_ERROR ("Failed to accept connection");
+    g_object_unref(cancellable);
     return GST_RTSP_ERROR;
   } else {
     g_socket_close (src->tcp, NULL);