sched/debug: Correct printing for rq->nr_uninterruptible
author晏艳(采苓) <yanyan.yan@antgroup.com>
Sat, 6 May 2023 07:42:53 +0000 (15:42 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 8 May 2023 08:58:39 +0000 (10:58 +0200)
Commit e6fe3f422be1 ("sched: Make multiple runqueue task counters
32-bit") changed the type for rq->nr_uninterruptible from "unsigned
long" to "unsigned int", but left wrong cast print to
/sys/kernel/debug/sched/debug and to the console.

For example, nr_uninterruptible's value is fffffff7 with type
"unsigned int", (long)nr_uninterruptible shows 4294967287 while
(int)nr_uninterruptible prints -9. So using int cast fixes wrong
printing.

Signed-off-by: Yan Yan <yanyan.yan@antgroup.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20230506074253.44526-1-yanyan.yan@antgroup.com
kernel/sched/debug.c

index 0b2340a..066ff1c 100644 (file)
@@ -777,7 +777,7 @@ static void print_cpu(struct seq_file *m, int cpu)
 #define P(x)                                                           \
 do {                                                                   \
        if (sizeof(rq->x) == 4)                                         \
-               SEQ_printf(m, "  .%-30s: %ld\n", #x, (long)(rq->x));    \
+               SEQ_printf(m, "  .%-30s: %d\n", #x, (int)(rq->x));      \
        else                                                            \
                SEQ_printf(m, "  .%-30s: %Ld\n", #x, (long long)(rq->x));\
 } while (0)