Bluetooth: mgmt: Remove unneeded variable
authorMinghao Chi <chi.minghao@zte.com.cn>
Tue, 18 Jan 2022 07:50:33 +0000 (07:50 +0000)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 4 Mar 2022 15:10:49 +0000 (16:10 +0100)
Return value from mgmt_cmd_complete() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/mgmt.c

index 71aff6e..e0d36d1 100644 (file)
@@ -8630,7 +8630,6 @@ static int get_adv_size_info(struct sock *sk, struct hci_dev *hdev,
        struct mgmt_cp_get_adv_size_info *cp = data;
        struct mgmt_rp_get_adv_size_info rp;
        u32 flags, supported_flags;
-       int err;
 
        bt_dev_dbg(hdev, "sock %p", sk);
 
@@ -8657,10 +8656,8 @@ static int get_adv_size_info(struct sock *sk, struct hci_dev *hdev,
        rp.max_adv_data_len = tlv_data_max_len(hdev, flags, true);
        rp.max_scan_rsp_len = tlv_data_max_len(hdev, flags, false);
 
-       err = mgmt_cmd_complete(sk, hdev->id, MGMT_OP_GET_ADV_SIZE_INFO,
-                               MGMT_STATUS_SUCCESS, &rp, sizeof(rp));
-
-       return err;
+       return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_GET_ADV_SIZE_INFO,
+                                MGMT_STATUS_SUCCESS, &rp, sizeof(rp));
 }
 
 static const struct hci_mgmt_handler mgmt_handlers[] = {