USB: pl2303: add error handling to set_control_lines
authorJohan Hovold <jhovold@gmail.com>
Sun, 29 Dec 2013 18:23:02 +0000 (19:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Jan 2014 20:31:47 +0000 (12:31 -0800)
Add error handling to set_control_lines.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/pl2303.c

index 4058cee..1fe8545 100644 (file)
@@ -269,12 +269,13 @@ static int pl2303_set_control_lines(struct usb_serial_port *port, u8 value)
        struct usb_device *dev = port->serial->dev;
        int retval;
 
+       dev_dbg(&port->dev, "%s - %02x\n", __func__, value);
+
        retval = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
                                 SET_CONTROL_REQUEST, SET_CONTROL_REQUEST_TYPE,
                                 value, 0, NULL, 0, 100);
-
-       dev_dbg(&port->dev, "%s - value = %d, retval = %d\n", __func__,
-               value, retval);
+       if (retval)
+               dev_err(&port->dev, "%s - failed: %d\n", __func__, retval);
 
        return retval;
 }