hwmon: (ina3221) Validate shunt resistor value from DT
authorNicolin Chen <nicoleotsuka@gmail.com>
Mon, 8 Oct 2018 21:24:51 +0000 (14:24 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 11 Oct 2018 03:37:13 +0000 (20:37 -0700)
The input->shunt_resistor is int type while the value from DT is
unsigned int. Meanwhile, a divide-by-zero error would happen if
the value is 0. So this patch just simply validates the value.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ina3221.c

index c3a497a..4f3ed24 100644 (file)
@@ -536,8 +536,14 @@ static int ina3221_probe_child_from_dt(struct device *dev,
        of_property_read_string(child, "label", &input->label);
 
        /* Overwrite default shunt resistor value optionally */
-       if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val))
+       if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val)) {
+               if (val < 1 || val > INT_MAX) {
+                       dev_err(dev, "invalid shunt resistor value %u of %s\n",
+                               val, child->name);
+                       return -EINVAL;
+               }
                input->shunt_resistor = val;
+       }
 
        return 0;
 }