iommu: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:09 +0000 (08:47 -0600)
committerJoerg Roedel <jroedel@suse.de>
Wed, 22 Mar 2023 13:54:42 +0000 (14:54 +0100)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20230310144709.1542910-1-robh@kernel.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/arm/arm-smmu/arm-smmu.c
drivers/iommu/ipmmu-vmsa.c

index 2ff7a72..d0843ca 100644 (file)
@@ -139,7 +139,7 @@ static int arm_smmu_register_legacy_master(struct device *dev,
        int err;
 
        np = dev_get_dev_node(dev);
-       if (!np || !of_find_property(np, "#stream-id-cells", NULL)) {
+       if (!np || !of_property_present(np, "#stream-id-cells")) {
                of_node_put(np);
                return -ENODEV;
        }
index bdf1a4e..f447030 100644 (file)
@@ -1014,7 +1014,7 @@ static int ipmmu_probe(struct platform_device *pdev)
         * the lack of has_cache_leaf_nodes flag or renesas,ipmmu-main property.
         */
        if (!mmu->features->has_cache_leaf_nodes ||
-           !of_find_property(pdev->dev.of_node, "renesas,ipmmu-main", NULL))
+           !of_property_present(pdev->dev.of_node, "renesas,ipmmu-main"))
                mmu->root = mmu;
        else
                mmu->root = ipmmu_find_root();