Fixing prevent defects in libprivilege-control:

* 63125; Minor; Unchecked return value; In function app_uninstall_remove_early_rules
  in src/privilege-control.c (defect changed to false positive)
* 63145; Critical; Dereference after null check; In function main
  in rule_loader/rule_loader.c
* 63146; Critical; Dereference after null check; In function
  app_uninstall_remove_early_rules in src/privilege-control.c

[Issue#]        N/A
[Bug/Feature]   There are 3 prevent issues to solve.
[Cause]         N/A
[Solution]      N/A
[Verification]  Running libprivilege tests. All should pass.

Change-Id: I5298a40ebef24286fec1149b48cac33e32753c00

diff --git a/rule_loader/rule_loader.c b/rule_loader/rule_loader.c
index eaf9514..ba8c39e 100644 (file)
--- a/rule_loader/rule_loader.c
+++ b/rule_loader/rule_loader.c
@@ -64,6 +64,7 @@ error:
         free(installed_app_list);
     }
 
-    fclose(log_file);
+    if (log_file)
+        fclose(log_file);
     return ret;
 }

diff --git a/src/privilege-control.c b/src/privilege-control.c
index e99ccbf..25483f2 100644 (file)
--- a/src/privilege-control.c
+++ b/src/privilege-control.c
@@ -1619,7 +1619,9 @@ static int app_uninstall_remove_early_rules(const char *app_id)
 
 out:
 
-       sem_post(sem);
+       if (sem)
+               sem_post(sem);
+       // Should we check unlink?
        sem_unlink(PRIVILEGE_CONTROL_UNINSTALL_SEM);
        return ret;
 }