ci: Fix a minor issue in prepare-artifacts.sh script
authorRohan Garg <rohan.garg@collabora.com>
Thu, 26 Aug 2021 13:00:40 +0000 (15:00 +0200)
committerMarge Bot <eric+marge@anholt.net>
Mon, 30 Aug 2021 14:52:08 +0000 (14:52 +0000)
bash is whitespace sensitive.
https://github.com/koalaman/shellcheck/wiki/SC1020

This was noticed from the logs of a CI job
https://gitlab.freedesktop.org/mesa/mesa/-/jobs/13158779
There was no fallout from this bug as not having this variable defined
leads to the right behavior, and defining it to 1 leads to a error
which consequently also leads to the right behaviour.

Signed-off-by: Rohan Garg <rohan.garg@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12562>

.gitlab-ci/prepare-artifacts.sh

index 393329effc496290e6025d1d9a0d4fd84ef101c8..bbc37ef141946d8585a813025879390b971ec64b 100755 (executable)
@@ -18,7 +18,7 @@ if [ -n "$CROSS" ]; then
 else
     STRIP="strip"
 fi
-if [ -z "$ARTIFACTS_DEBUG_SYMBOLS"]; then
+if [ -z "$ARTIFACTS_DEBUG_SYMBOLS" ]; then
     find install -name \*.so -exec $STRIP {} \;
 fi