Bluetooth: mgmt: Avoid using magic number in status code
authorSzymon Janc <szymon.janc@tieto.com>
Thu, 13 Dec 2012 14:11:21 +0000 (15:11 +0100)
committerGustavo Padovan <gustavo.padovan@collabora.co.uk>
Wed, 9 Jan 2013 19:05:06 +0000 (17:05 -0200)
Use MGMT_STATUS_SUCCESS for success return code.

Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
net/bluetooth/mgmt.c

index ef38582..e5502a5 100644 (file)
@@ -2259,7 +2259,7 @@ static int add_remote_oob_data(struct sock *sk, struct hci_dev *hdev,
        if (err < 0)
                status = MGMT_STATUS_FAILED;
        else
-               status = 0;
+               status = MGMT_STATUS_SUCCESS;
 
        err = cmd_complete(sk, hdev->id, MGMT_OP_ADD_REMOTE_OOB_DATA, status,
                           &cp->addr, sizeof(cp->addr));
@@ -2283,7 +2283,7 @@ static int remove_remote_oob_data(struct sock *sk, struct hci_dev *hdev,
        if (err < 0)
                status = MGMT_STATUS_INVALID_PARAMS;
        else
-               status = 0;
+               status = MGMT_STATUS_SUCCESS;
 
        err = cmd_complete(sk, hdev->id, MGMT_OP_REMOVE_REMOTE_OOB_DATA,
                           status, &cp->addr, sizeof(cp->addr));
@@ -2515,7 +2515,7 @@ static int block_device(struct sock *sk, struct hci_dev *hdev, void *data,
        if (err < 0)
                status = MGMT_STATUS_FAILED;
        else
-               status = 0;
+               status = MGMT_STATUS_SUCCESS;
 
        err = cmd_complete(sk, hdev->id, MGMT_OP_BLOCK_DEVICE, status,
                           &cp->addr, sizeof(cp->addr));
@@ -2540,7 +2540,7 @@ static int unblock_device(struct sock *sk, struct hci_dev *hdev, void *data,
        if (err < 0)
                status = MGMT_STATUS_INVALID_PARAMS;
        else
-               status = 0;
+               status = MGMT_STATUS_SUCCESS;
 
        err = cmd_complete(sk, hdev->id, MGMT_OP_UNBLOCK_DEVICE, status,
                           &cp->addr, sizeof(cp->addr));