staging: r8188eu: use ether_addr_equal in OnAction
authorMartin Kaiser <martin@kaiser.cx>
Mon, 31 Oct 2022 20:51:41 +0000 (21:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 Nov 2022 07:17:47 +0000 (08:17 +0100)
Use ether_addr_equal to compare two mac addresses in OnAction.

Both struct ieee80211_mgmt and struct eeprom_priv's mac_addr component
are 2-byte aligned.

Suggested-by: Joe Perches <joe@perches.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20221031205140.124682-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c

index e985fc5..6679d40 100644 (file)
@@ -3823,7 +3823,7 @@ static void OnAction(struct adapter *padapter, struct recv_frame *precv_frame)
 {
        struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;
 
-       if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))
+       if (!ether_addr_equal(myid(&padapter->eeprompriv), mgmt->da))
                return;
 
        switch (mgmt->u.action.category) {